[PATCH] D112725: [LoopVectorize] Extract the last lane from a uniform store

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:5477
+      // to the worklist as they demand the first lane. Since store instructions
+      // demand the last lane, we instead add these to Uniforms.
+      if (Legal->isUniformMemOp(I)) {
----------------
nit: perhaps throw in an `only` (e.g. we instead add these to Uniforms only). Otherwise it may sound like the other instructions won't get added to `Uniforms`, which they will eventually.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112725/new/

https://reviews.llvm.org/D112725