[PATCH] D113342: [LoopRotate] Add branch_weights metadata for rotated branch

Sat Nov 6 20:54:35 PDT 2021

bin.cheng added a comment.

In D113342#3113525 <https://reviews.llvm.org/D113342#3113525>, @lebedev.ri wrote:

> Indeed, https://godbolt.org/z/cM8P49qxo, but it sounds like a BPI problem?

Yes, it's a BPI problem, but it's difficult to handle in BPI without additional information.  Please see my comment in D113345 <https://reviews.llvm.org/D113345>.

Thanks

================
Comment at: llvm/test/Transforms/LoopRotate/callbr.ll:99
 declare i32 @n(i8*, i8*)  #0

 attributes #0 = { "use-soft-float"="false" }
----------------
xbolva00 wrote:
> Check prof metadata?
> 
> 
> CHECK: [[PROF]] = !{!"branch_weights", i32 ..., i32 ...}
> 
> Check prof metadata?
> 
> 
> CHECK: [[PROF]] = !{!"branch_weights", i32 ..., i32 ...}
> 

Right, once confirm the idea is heading to right direction, I will add metadata check.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113342/new/

https://reviews.llvm.org/D113342