[PATCH] D113335: [X86] Preserve FPSW when popping x87 stack

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InsertWait.cpp:65
 /// check if the instruction is X87 instruction
-static bool isX87Instruction(MachineInstr &MI) {
+bool X86::isX87Instruction(MachineInstr &MI) {
   for (const MachineOperand &MO : MI.operands()) {
----------------
This function should move to X86InstrInfo.cpp if it is going to be in the X86InstrInfo.h header.


================
Comment at: llvm/test/CodeGen/X86/x87-stack-pop.mir:1
+# RUN: llc -mtriple=i686-- -run-pass x86-codegen -O2 -o - %s | FileCheck %s
+
----------------
Please use update_mir_test_checks.py


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113335/new/

https://reviews.llvm.org/D113335