[PATCH] D113351: [DAG] Add BuildVectorSDNode::getConstantRawBits helper

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAGNodes.h:2056
+  /// undefined elements are flagged in \p UndefElements.
+  bool getConstantRawBits(bool IsLE, unsigned DstEltSizeInBits,
+                          SmallVectorImpl<APInt> &RawBitElements,
----------------
IsLE could probably use some documentation or spell it out. I didn't read LE as little endian at first. I initially read it as "less than or equal" which didn't make any sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113351/new/

https://reviews.llvm.org/D113351