[PATCH] D112843: [aarch64/mac] Correctly disassemble @TLVPPAGE(OFF) relocs

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 6 19:07:10 PDT 2021


MaskRay added a comment.

`llvm-objdump --macho -d` can reproduce the issue as well. Perhaps perfer llvm-objdump which is used more frequently in tests.

The disassembly logic appears to be `llvm/tools/llvm-objdump/MachODump.cpp` specific.
Perhaps a better place is `llvm/test/tools/llvm-objdump/MachO/` (may need to duplicate the test a bit)



================
Comment at: llvm/test/MC/AArch64/arm64-tls-modifiers-darwin.s:18
+; CHECK-DIS: 0000000000000000 adrp x2, _var at TLVPPAGE
+; CHECK-DIS: 0000000000000004 ldr x0, [x15, _var at TLVPPAGEOFF]
+; CHECK-DIS: 0000000000000008 add x30, x0, _var at TLVPPAGEOFF
----------------
If you switch to `llvm-objdump --macho -d --no-show-raw-insn`, you can omit the leading addresses and use `CHECK-DIS-NEXT:` instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112843/new/

https://reviews.llvm.org/D112843



More information about the llvm-commits mailing list