[PATCH] D113301: [NFC][llvm-libtool-darwin]Remove unnecessary conditionals around errors.

Roger Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 6 17:33:51 PDT 2021


Roger marked 2 inline comments as done.
Roger added inline comments.


================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:508
     llvm::stable_sort(*Slices);
-    if (Error E = writeUniversalBinary(*Slices, OutputFile))
-      return E;
+    return writeUniversalBinary(*Slices, OutputFile);
   }
----------------
alexander-shaposhnikov wrote:
> drodriguez wrote:
> > For this last case, if you want to remove the `else` branch, I think it will fit more with the code style: https://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return
> yeah, i think this 'else' should be removed
Done :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113301/new/

https://reviews.llvm.org/D113301



More information about the llvm-commits mailing list