[PATCH] D113350: [X86][Costmodel] `getReplicationShuffleCost()`: implement cost model for 32/64 bit-wide elements with AVX512F

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 6 14:17:02 PDT 2021


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:3702-3704
+    // Do we actually demand this particular element to be replicated?
+    if (!DemandedSrcElts[SrcEltIdx] || !DemandedReplicatedElts[EltIdx])
+      return;
----------------
I guess two sources of demanded elts was a wrong choice,
`DemandedSrcElts` is implied by `DemandedReplicatedElts`,
yet `DemandedSrcElts` provides less knowledge than `DemandedReplicatedElts`,
and changing `DemandedReplicatedElts` to `DemandedIndices`
would also be lossy. I'll drop `DemandedSrcElts` later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113350/new/

https://reviews.llvm.org/D113350



More information about the llvm-commits mailing list