[PATCH] D113238: [llvm-profgen] Fix index out of bounds error while using ip.advance

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 5 16:38:11 PDT 2021


wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

lgtm, thanks.



================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:673-675
+    if (Index == getCodeOffsetsSize() - 1)
+      break;
     Offset = CodeAddrOffsets[++Index];
----------------
Similarly, would be nice to use abstractions here instead of dealing with index directly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113238/new/

https://reviews.llvm.org/D113238



More information about the llvm-commits mailing list