[PATCH] D113313: [NFC][TTI] Add/extract `getReplicationShuffleCost()` method, deduplicate it's implementations
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 5 15:14:18 PDT 2021
lebedev.ri updated this revision to Diff 385201.
lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.
In D113313#3112925 <https://reviews.llvm.org/D113313#3112925>, @RKSimon wrote:
> Is it due to this being mainly used for interleaved ops that you didn't integrate it into the ShuffleKind enum?
Basically yes. Then we'd always have to construct a shuffle mask,
only to then call `ShuffleVectorInst::isReplicationMask()` on it.
It just seems backwards.
D113324 <https://reviews.llvm.org/D113324> is the only used that i plan on having.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113313/new/
https://reviews.llvm.org/D113313
Files:
llvm/include/llvm/Analysis/TargetTransformInfo.h
llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
llvm/include/llvm/CodeGen/BasicTTIImpl.h
llvm/lib/Analysis/TargetTransformInfo.cpp
llvm/lib/Target/X86/X86TargetTransformInfo.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113313.385201.patch
Type: text/x-patch
Size: 10384 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211105/0c6525cb/attachment.bin>
More information about the llvm-commits
mailing list