[PATCH] D107378: Make enum iteration with seq safe by default

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 5 14:58:08 PDT 2021


kuhar added a comment.

In D107378#3112933 <https://reviews.llvm.org/D107378#3112933>, @vvereschaka wrote:

> Hi @kuhar,
>
> looks like these changes are reason of bunch of build warnings on the windows builders (VC). I see more than 1000 additional warnings such as
>
>   C:\buildbot\as-builder-1\x-armv7l\llvm-project\llvm\include\llvm/ADT/Sequence.h(119): warning C4309: 'static_cast': truncation of constant value
>   C:\buildbot\as-builder-1\x-armv7l\llvm-project\llvm\include\llvm/ADT/Sequence.h(120): warning C4309: 'static_cast': truncation of constant value
>   C:\buildbot\as-builder-1\x-armv7l\llvm-project\llvm\include\llvm/ADT/Sequence.h(119): warning C4309: 'static_cast': truncation of constant value
>   C:\buildbot\as-builder-1\x-armv7l\llvm-project\llvm\include\llvm/ADT/Sequence.h(120): warning C4309: 'static_cast': truncation of constant value
>
> starting at this build https://lab.llvm.org/buildbot/#/builders/60/builds/5295
>
> would you take care of them?
> Thank you.

Hi @vvereschaka,

These warnings seem to originate in the existing code, unmodified by this commit (`template <typename T, typename U> bool canTypeFitValue(const U Value) {`). I think this code was contributed by @gchatelet?
I don't have access to a Windows machine and it's difficult for me to tell how to address these warnings without more details.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107378/new/

https://reviews.llvm.org/D107378



More information about the llvm-commits mailing list