[PATCH] D113234: Extend obj2yaml to optionally preserve raw __LINKEDIT/__DATA segments.

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexander-shaposhnikov added inline comments.


================
Comment at: llvm/tools/obj2yaml/obj2yaml.cpp:27
+             "parsing them:"),
+    cl::values(clEnumVal(data, "__DATA"), clEnumVal(linkedit, "__LINKEDIT")));
+
----------------
I'd like just to point out that in general users can specify their one segment names,
e.g. via attribute((section("__CUSTOMSEG,__text")), if you use enum here they won't be able to dump them
without modifying the tool
(Phabricator doesn't like double underscore, the name above is <double underscore>CUSTOMSEG)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113234/new/

https://reviews.llvm.org/D113234