[PATCH] D112961: [fir] Add fir.extract_value and fir.insert_value conversion

Fri Nov 5 12:51:19 PDT 2021

clementval added inline comments.

================
Comment at: flang/lib/Optimizer/CodeGen/DescriptorModel.h:90
+template <>
+TypeBuilderFunc getModel<Fortran::ISO::CFI_index_t>() {
+  return [](mlir::MLIRContext *context) -> mlir::Type {
----------------
Meinersbur wrote:
> This breaks the [[ https://lab.llvm.org/buildbot/#/builders/172/builds/5299 | windows build ]]:
> ```
> C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\flang\lib\Optimizer\CodeGen\DescriptorModel.h(95): error C2766: explicit specialization; 'fir::TypeBuilderFunc (__cdecl *fir::getModel<__int64>(void))(mlir::MLIRContext *)' has already been defined
> C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\flang\lib\Optimizer\CodeGen\DescriptorModel.h(70): note: see previous definition of 'getModel'
> ```
> 
> `CFI_index_t` is a typedef of `ptrdiff_t` which is a 64 bit signed integer. That is, the same as `getModel<long long>` template specialization. Don't know why it works under Linux or why the Windows pre-merge check didn't run.
> 
https://github.com/llvm/llvm-project/commit/d75ab7d548c020f37ed3391a0002b206336fe46e should fix the buildbot for the time being. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112961/new/

https://reviews.llvm.org/D112961