[PATCH] D113295: [flang] Transform `fir.end` to an empty statement

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In D113295#3112136 <https://reviews.llvm.org/D113295#3112136>, @awarzynski wrote:

> Without the change in "FIROps.td" I was getting the following error:
>
>   error: custom op 'fir.end' has no custom assembly form
>
> I'm not that familiar with the design, so perhaps this is not the right approach?





================
Comment at: flang/include/flang/Optimizer/Dialect/FIROps.td:812
+
+  let parser = "return mlir::success();";
 }
----------------
You need this to be able to parse the "pretty" form. But do you need one?


================
Comment at: flang/test/Fir/convert-to-llvm.fir:331
+
+fir.end
+
----------------
You could test it with just `"fir.end"() : () -> ()` and not define a custom parser.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113295/new/

https://reviews.llvm.org/D113295