[PATCH] D113258: [flang] Set the addendum when establishing pointer section in descriptor

Peter Klausler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 5 09:15:27 PDT 2021


klausler accepted this revision.
klausler added a comment.
This revision is now accepted and ready to land.

Thank you so much for finding this!



================
Comment at: flang/runtime/descriptor.cpp:244
   raw_.rank = newRank;
+  if (const auto *sourceAddendum = source.Addendum()) {
+    auto *addendum = Addendum();
----------------
Please use braced initialization here in the runtime, and you can put the `auto *addendum{Addendum()}` into the `if` statement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113258/new/

https://reviews.llvm.org/D113258



More information about the llvm-commits mailing list