[PATCH] D113283: [fir] Add test for FIR types conversion

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/test/Fir/types-to-llvm.fir:9
+func private @foo0(%arg0: !fir.array<10x10xi64>)
+// CHECK: !llvm.array<10 x array<10 x i64>>
+func private @foo1(%arg0: !fir.array<?xf32>)
----------------
awarzynski wrote:
> Could you use this idiom for other cases too? Otherwise, there's no guarantee that a particular `CHECK` line matches on the line that we want it to match.
Why not all on a single line:

```
// CHECK: foo0(%{{.*}}: !llvm.array<10 x array<10 x i64>>)
```
I find it less "verbose" personnally. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113283/new/

https://reviews.llvm.org/D113283