[PATCH] D113214: [IR][ShuffleVector] Introduce `isReplicationMask()` matcher

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 5 07:53:20 PDT 2021


lebedev.ri added inline comments.


================
Comment at: llvm/unittests/IR/InstructionsTest.cpp:1133
+
+TEST(InstructionsTest, ShuffleMaskIsReplicationMask_undef) {
+  for (int ReplicationFactor : seq_inclusive(1, 6)) {
----------------
rupprecht wrote:
> These two exhaustive test cases take an extremely long time to test (3+ minutes for each one). Would it make sense to use `#ifdef EXPENSIVE_CHECKS` for these two?
They take 1 and 2 seconds for me.
How long do tests in `ConstantRangeTest.cpp` take for you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113214/new/

https://reviews.llvm.org/D113214



More information about the llvm-commits mailing list