[PATCH] D106314: [Utils] Add -compilation-dir flag to prepare-code-coverage-artifact.py

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Very belated comment: It's a bit weird that `index.html` has paths like `../../lld/COFF/COFFLinkerContext.cpp` but if you click it the generated file for that starts with `lld/COFF/COFFLinkerContext.cpp`.

Without `--compilation-dir` and `-fcoverage-compilation-dir=.` it's also inconsistent (`../../lld/COFF/COFFLinkerContext.cpp` and `/Users/thakis/src/llvm-project/lld/COFF/COFFLinkerContext.cpp`) so it's not a new thing from this flag. But maybe it'd be nice if index and detail page used the same string? Not sure.

(Feel free to ignore this comment; just thought I should mention this discrepancy somewhere.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106314/new/

https://reviews.llvm.org/D106314