[PATCH] D113213: [NFC] Move CombinationGenerator from Exegesis to ADT

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 5 06:33:19 PDT 2021


lebedev.ri added inline comments.


================
Comment at: llvm/include/llvm/ADT/CombinationGenerator.h:15-16
+///
+/// It is important to think of input as vector-of-vectors, where the
+/// outer vector is the variable space, and inner vector is choice space.
+/// The number of choices for each variable can be different.
----------------
courbet wrote:
> I'm not sure this is very relevant here.
I think this is useful for understanding of the algorithm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113213/new/

https://reviews.llvm.org/D113213



More information about the llvm-commits mailing list