[PATCH] D113215: [NFC][llvm-libtool-darwin] Clean up names
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 5 02:54:54 PDT 2021
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
It would be preferable if this change was made first before your other changes, I think. That way you don't add stuff that is just going to be immediately changed again. Other than that and the nit, LGTM.
================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:266
+ return createFileError(FileName, NewMemberOrErr.takeError());
+ auto& NewMember = *NewMemberOrErr;
----------------
Nit: clang-format your changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113215/new/
https://reviews.llvm.org/D113215
More information about the llvm-commits
mailing list