[PATCH] D112961: [fir] Add fir.extract_value and fir.insert_value conversion

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:237
+    return {};
+  }
+
----------------
mehdi_amini wrote:
> Function isn't used?
Not needed anymore. Removed for now. 


================
Comment at: flang/lib/Optimizer/CodeGen/TypeConverter.h:143
+    return mlir::Type();
   }
 
----------------
mehdi_amini wrote:
> Is all the code related to the box type conversion coupled to the rest of this patch? I don't see where it is tested and it seems that the tests for  fir.extract_value and fir.insert_value lowering aren't involving the box type?
It was in my plan to bring `!fir.box` conversion along in this patch but in order to test it well it requires to bring along some other code. It's better to do this in another revision focused on that. Remove the code in this patch for now. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112961/new/

https://reviews.llvm.org/D112961