[PATCH] D113173: [AsmPrinter][ORE] use correct opcode name
ChenZheng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 4 20:52:13 PDT 2021
shchenz marked an inline comment as done.
shchenz added inline comments.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1418
for (auto &KV : MnemonicVec) {
- auto Name = (Twine("INST_") + KV.first.trim()).str();
+ auto Name = (Twine("INST_") + KV.first.trim().take_until([](char c) {
+ return c == ' ' || c == '\t' || c == '\n' || c == '\v' ||
----------------
jsji wrote:
> Can we just use getToken()?
>
> ```
> - auto Name = (Twine("INST_") + KV.first.trim()).str();
> + auto Name = (Twine("INST_") + getToken(KV.first).first.trim()).str();
> ```
Yes, `getToken()` is simpiler
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113173/new/
https://reviews.llvm.org/D113173
More information about the llvm-commits
mailing list