[PATCH] D113083: [flang] Add a semantics test for co_max

Damian Rouson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 4 17:38:46 PDT 2021


rouson updated this revision to Diff 384925.
rouson added a comment.

1. Add co_max test to expectedly failed list.
2. Replaced non-ASCII characters.
3. Correct expected error message.
4. Update run directive to use test_errors.py.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113083/new/

https://reviews.llvm.org/D113083

Files:
  flang/test/Semantics/collectives03.f90


Index: flang/test/Semantics/collectives03.f90
===================================================================
--- /dev/null
+++ flang/test/Semantics/collectives03.f90
@@ -0,0 +1,46 @@
+! RUN: %python %S/test_errors.py %s %flang_fc1
+! XFAIL: *
+! Check for semantic errors in co_max() subroutine calls
+! To Do: add co_max to the evaluation stage
+
+module test_co_max
+  implicit none
+
+contains
+
+  subroutine test
+  
+    integer i, status
+    real vector(1)
+    real array(1,1,1, 1,1,1, 1,1,1, 1,1,1, 1,1,1)
+    character(len=1) string, message
+  
+    ! correct calls, should produce no errors
+    call co_max(i)
+    call co_max(i,   1)
+    call co_max(i,   1,              status)
+    call co_max(i,   1,              stat=status)
+    call co_max(i,   1,                           errmsg=message)
+    call co_max(i,   1,              stat=status, errmsg=message)
+    call co_max(i,   result_image=1, stat=status, errmsg=message)
+    call co_max(a=i, result_image=1, stat=status, errmsg=message)
+
+    call co_max(array,  result_image=1, stat=status, errmsg=message)
+    call co_max(vector, result_image=1, stat=status, errmsg=message)
+    call co_max(string, result_image=1, stat=status, errmsg=message)
+  
+    ! the error is seen as an incorrect type for the stat= argument
+    !ERROR: Actual argument for 'stat=' has bad type 'CHARACTER(KIND=1,LEN=1_8)'
+    call co_max(i, 1, message)
+
+    ! the error is seen as too many arguments to the co_max() call
+    !ERROR: too many actual arguments for intrinsic 'co_max'
+    call co_max(i,   result_image=1, stat=status, errmsg=message, 3.4)
+  
+    ! keyword argument with incorrect type
+    !ERROR: unknown keyword argument to intrinsic 'co_max'
+    call co_max(fake=3.4)
+  
+  end subroutine
+
+end module test_co_max


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113083.384925.patch
Type: text/x-patch
Size: 1806 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211105/5c05a3c1/attachment.bin>


More information about the llvm-commits mailing list