[PATCH] D113230: [WebAssembly] Fix fixBrTableIndex removing instruction without checking uses

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 4 17:26:15 PDT 2021


aardappel added a comment.

There might be a more elegant way to test if an instruction still has users for its def/reg, anyone know?

Also I could add a test for this.. this particular situation does not come up in C/C++, but I could de-compile the Rust generated bitcode (see linked bug) to ll and generate a test from that. Not sure how useful that is though, as `eraseFromParent` was clearly wrong here and this is the code that should have been there in the first place.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113230/new/

https://reviews.llvm.org/D113230



More information about the llvm-commits mailing list