[PATCH] D112063: [lld][ELF] Add first bits to support relocation relaxations for AArch64

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D112063#3109987 <https://reviews.llvm.org/D112063#3109987>, @alexander-shaposhnikov wrote:

> ping

I know this has been updated and will take the second look:)

(
FWIW I think we should not rush into this feature. GOT optimization (s/linker relaxations/GOT optimization/) is a very large change.

- We should ensure the ABI https://github.com/ARM-software/abi-aa/pull/106 is merged before this one.
- https://github.com/ARM-software/abi-aa/pull/106 needs consensus about the direction.

)

I am also a bit concerned about the relocation processing complexity, so I am exploring alternatives like D113228 <https://reviews.llvm.org/D113228>.



================
Comment at: lld/test/ELF/aarch64-adrp-ldr-got-symbols.s:12
+
+## Case 1. Symbol 'x' is preemptible, no relaxations should be applied.
+# RUN: ld.lld -shared %t-global.o -o %t-preemptible.so
----------------
`Case [[#]]` is usually unnecessary. Because sometimes you may want to add a new test between two, having case numbers requires adjusting the order.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112063/new/

https://reviews.llvm.org/D112063