[PATCH] D109359: [TableGen] Emit a warning for unused template args

Geoffrey Martin-Noble via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 4 12:20:59 PDT 2021


GMNGeoffrey added a comment.

In D109359#3109498 <https://reviews.llvm.org/D109359#3109498>, @Paul-C-Anagnostopoulos wrote:

> I vote for something explicit. An unused field seems like a hack, no?

I mean so does casting to void :-) I agree that something explicit would be better. I don't love adding unused fields. If it's just some trick, I much prefer an approach that doesn't have any side-effects, like the `defvar` suggestion (I don't understand why that doesn't work).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109359/new/

https://reviews.llvm.org/D109359



More information about the llvm-commits mailing list