[PATCH] D113198: [lld-macho] Clear resolvedReads cache

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 4 12:06:46 PDT 2021


keith marked an inline comment as done.
keith added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:181
 // would require altering many callers to track the state.
-static DenseMap<CachedHashStringRef, MemoryBufferRef> resolvedReads;
+DenseMap<CachedHashStringRef, MemoryBufferRef> macho::resolvedReads;
 // Open a given file path and return it as a memory-mapped file.
----------------
int3 wrote:
> unrelated nit: I'm thinking that `resolvedReads` is a bit of an odd name since we don't usually talk about reads being resolved, only paths... how about `cachedReads`?
yea good point, I updated here since I'm expanding the instances of it anyways


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113198/new/

https://reviews.llvm.org/D113198



More information about the llvm-commits mailing list