[PATCH] D113157: [tests][X86] Merge call-structfp.ll with x32-function_pointer-3.ll

Harald van Dijk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 4 11:59:28 PDT 2021


hvdijk added inline comments.


================
Comment at: llvm/test/CodeGen/X86/x32-function_pointer-3.ll:34
+declare { i64, void ()* } @pr52357.a()
+define void @pr52357.b() {
+; CHECK-LABEL: pr52357.b:
----------------
MaskRay wrote:
> add nounwind to remove `.cfi_*` noise. Then consider using more `CHECK-NEXT`
> 
> Maybe consider regenerating the CHECK patterns with `update_llc_test_checks.py`
I do not want the two tests that basically test the same thing, in slightly different cases, to test things differently: the `CHECK` lines here are written to match those of the existing test that was already in this file. I had an auto-generated test earlier and specifically updated it to use this file's style.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113157/new/

https://reviews.llvm.org/D113157



More information about the llvm-commits mailing list