[PATCH] D91087: [AArch64] Select PAC/PACGA for ptrauth.sign/sign_generic.

[Ahmed Bougacha via Phabricator via llvm-commits]

ab added a comment.

In D91087#3097889 <https://reviews.llvm.org/D91087#3097889>, @apazos wrote:

> I wonder if we could have these tests be generic for aarch64 target.
> These intrinsics implementation don't have anything dependent on Apple ABI.

That ship has sailed I think ;)  A large chunk of tests use different targets depending on who wrote them, and I guess that's okay precisely because the target differences aren't relevant to the tests.
That's a lot less true for the logic around lowering global references and constants and whatnot, I'm sure that looks quite different for non-darwin (and maybe that'll be enough to justify splitting the test file altogether, the ones I have for those features cover a lot of darwin-specific subtleties that aren't relevant elsewhere)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91087/new/

https://reviews.llvm.org/D91087