[PATCH] D109359: [TableGen] Emit a warning for unused template args

Geoffrey Martin-Noble via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 4 10:17:50 PDT 2021


GMNGeoffrey added a comment.

In D109359#3109384 <https://reviews.llvm.org/D109359#3109384>, @Paul-C-Anagnostopoulos wrote:

> I suggested an 'unused' statement above.

Yeah something like that seems fine to me. Also fine with a useless assignment, if such a thing is possible

> With it, we should be able to make this option on by default.

It appears to already be on by default :-(

> I don't think it's a good idea to completely disallow unused arguments.

Agreed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109359/new/

https://reviews.llvm.org/D109359



More information about the llvm-commits mailing list