[PATCH] D111358: TargetLibraryInfo checker tool

[Renato Golin via Phabricator via llvm-commits]

rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

It's much clearer now, thanks for the updates!

This now looks good to me, but maybe wait a few days to make sure no one else has any further comments.

Thanks!



================
Comment at: llvm/docs/CommandGuide/llvm-tli-checker.rst:50
+  A base directory to prepend to each library file path. This is handy
+  when there are a number of library files all in the same directory.
+
----------------
probinson wrote:
> rengolin wrote:
> > So, the syntax:
> > 
> >     llvm-tli-checker ... --libdir=foo/bar a.o b.o c.o
> > 
> > will check against:
> >  * foo/bar/a.o
> >  * foo/bar/b.o
> >  * foo/bar/c.o
> > 
> > If so, couldn't this just be `foo/bar/*` and let the shell expand it?
> That could work.  In my use case, the list of files to check is fixed, but I wanted to check against various releases, so it was easiest to put the list of files in a response file and then do `--libdir=foo/bar @myliblist.txt` for each release directory.
> Also each foo/bar has many more files than just the libc/libm equivalents, and it's faster to look only at the specific files I want, so wildcarding would cost time and generate noise in the output.
> I'd prefer to keep the option; I'll add a note about the response-file use case.
I see, makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111358/new/

https://reviews.llvm.org/D111358