[PATCH] D111301: [VPlan] Make sure recurrence splice is not inserted between phis.

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 4 09:16:56 PDT 2021


Ayal added a comment.

In D111301#3108536 <https://reviews.llvm.org/D111301#3108536>, @fhahn wrote:

> ping :)
>
> @Ayal does the clarification why this is needed make sense?
>
>> (from inline comment)
>> Ok I now what phi-like case I originally hit: if the previous value is an induction value! So I think we still need the special handling?

Clarification indeed makes sense, induction feeding a FOR should presumably be handled, not being a 2nd-order recurrence (SOR).

So we may indeed still need the special handling - along with special test(s); perhaps using i-1 inside a "for i" loop? Would also be good to address/exclude/cover non-header phis - of replicated regions and blends.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111301/new/

https://reviews.llvm.org/D111301



More information about the llvm-commits mailing list