[PATCH] D113101: [Polly][Isl] Use the function unsignedFromIslSize to manage a isl::size object. NFCI

Thu Nov 4 09:00:16 PDT 2021

Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

LGTM, thanks for picking this up again.

================
Comment at: polly/lib/External/isl/include/isl/isl-noexceptions.h:201
 } // namespace isl
-
 #include <isl/id.h>
----------------
patacca wrote:
> Meinersbur wrote:
> > unrelated change?
> This one was a leftover blank space that was removed in this commit https://github.com/patacca/isl/commit/e704f73c88f0b4d88e62e447bdb732cf5914094b
> Since then nobody actually updated `isl-noexceptions.h`
Seems that was me. Different editors have different understanding of whether `\n` is a line terminator (i.e. even the last line ends with `\n`) or line separator (i.e. no `\n` on last line). See https://en.wikipedia.org/wiki/Newline#Interpretation

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113101/new/

https://reviews.llvm.org/D113101