[PATCH] D112450: support xcoff for llvm-nm

[Digger Lin via Phabricator via llvm-commits]

DiggerLin marked 7 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:144
 
+void reportWarning(Error Err, StringRef Input) {
+  assert(Err);
----------------
jhenderson wrote:
> # Move this function so that it isn't sandwiched by the `error` functions.
> # I think you can just use `WithColor::defaultWarningHandler` to replace most of the logic around `handleAllErrors` below.
> # For consistency with the `error` functions in this file, I'd just call this function `warn` rather than `reportWarning`.

if using WithColor::defaultWarningHandler(Error Warning)  directly , we  can not tell user which object file has the warning. 




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112450/new/

https://reviews.llvm.org/D112450