[PATCH] D113089: [fir] Add fir.select and fir.select_rank FIR to LLVM IR conversion patterns

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:196
+                           mlir::ConversionPatternRewriter &rewriter) {
+  // We could target the LLVM switch instruction, but it isn't part of the
+  // LLVM IR dialect.  Create an if-then-else ladder instead.
----------------
Just realized the LLVM IR dialect has the SwitchOp now. I'll rewrite the conversion to make use of it. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113089/new/

https://reviews.llvm.org/D113089