[PATCH] D109371: [RISCV][RFC] Add LLVM support for RISC-V overlay system

Thu Nov 4 07:34:49 PDT 2021

edward-jones added a comment.

In D109371#3099989 <https://reviews.llvm.org/D109371#3099989>, @jrtc27 wrote:

> In D109371#3099949 <https://reviews.llvm.org/D109371#3099949>, @edward-jones wrote:
>
>> Some of the previously changes made were undone in order to match the spec as-written (notably I undid the renaming of relocations).
>>
>> This could do with another review now because I don't expect this patch will change too much now unless the spec also changes.
>
> Aside from the comment I just made about this attitude on the corresponding Clang patch, standard RISC-V relocations can only be specified by the psABI, so the names absolutely can still be changed if the spec authors propose bad names.

Okay, I've opened an issue for renaming the relocation in the spec: https://github.com/riscv-software-src/riscv-overlay/issues/29

I'll try and drive the changes to the spec based on feedback first and only then request more feedback here.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109371/new/

https://reviews.llvm.org/D109371