[PATCH] D113101: [Polly][Isl] Use the function unsignedFromIslSize to manage a isl::size object. NFCI

Thu Nov 4 07:01:51 PDT 2021

patacca added a comment.

In D113101#3107313 <https://reviews.llvm.org/D113101#3107313>, @Meinersbur wrote:

> In D113101#3107069 <https://reviews.llvm.org/D113101#3107069>, @patacca wrote:
>
>> I've tested it with the llvm test suite and it's showing 1 test failing but it's not related to this patch (`MultiSource/Applications/lambda-0.1.3/lambda.test`)
>
> I remember I fixed the lambda failure. The buildbot shows green (http://meinersbur.de:8011/#/builders/76/builds/1306). Have you tested with the latest version of LLVM/Polly?

For some reason I cannot connect to the link you posted. Anyway after I tested it again with a fresh new build of llvm-suite the error in the lambda test disappeared.

================
Comment at: polly/lib/External/isl/include/isl/isl-noexceptions.h:201
 } // namespace isl
-
 #include <isl/id.h>
----------------
Meinersbur wrote:
> unrelated change?
This one was a leftover blank space that was removed in this commit https://github.com/patacca/isl/commit/e704f73c88f0b4d88e62e447bdb732cf5914094b
Since then nobody actually updated `isl-noexceptions.h`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113101/new/

https://reviews.llvm.org/D113101