[PATCH] D112919: [CSKY] Add CSKY 16-bit instruction format and encoding

[Renato Golin via Phabricator via llvm-commits]

rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/lib/Target/CSKY/CSKY.td:28
 
+def FeatureJAVA
+    : SubtargetFeature<"java", "HasJAVA", "true", "Enable java instructions">;
----------------
zixuan-wu wrote:
> rengolin wrote:
> > zixuan-wu wrote:
> > > rengolin wrote:
> > > > zixuan-wu wrote:
> > > > > rengolin wrote:
> > > > > > Huh! I haven't found any reference to Java instructions in either available manuals (in github).
> > > > > > 
> > > > > > I'm guessing this is similar to Arm's Jazelle extensions?
> > > > > > 
> > > > > > None of the instructions below marked with `HasJAVA` appear on the ISA document...
> > > > > > 
> > > > > > Perhaps better to leave it out for another commit once that part is public?
> > > > > for example, BPOPH has reference to it.
> > > > The documents you posted on the RFC (https://github.com/c-sky/csky-doc/) don't have it.
> > > > 
> > > > It has reference to `bpop16.h` and `bpop16.w` in section 5.3.2.5, but does not list it in the instruction section, so we're left wondering what that is.
> > > Oh, it's missing instructions in that doc, which may because of out-of-date.
> > Can you update that document before updating the code with non-public information?
> OK. I have updated the pdf document.
Thanks! It doesn't mention "java" but at least the instructions are there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112919/new/

https://reviews.llvm.org/D112919