[PATCH] D110995: [X86] combineMulToPMADDWD - handle any pow2 vector type and split to legal types

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 4 04:35:45 PDT 2021


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/madd.ll:588-590
+; SSE2-NEXT:    punpcklwd {{.*#+}} xmm2 = xmm2[0],xmm0[0],xmm2[1],xmm0[1],xmm2[2],xmm0[2],xmm2[3],xmm0[3]
+; SSE2-NEXT:    psraw $8, %xmm3
+; SSE2-NEXT:    punpcklwd {{.*#+}} xmm3 = xmm3[0],xmm0[0],xmm3[1],xmm0[1],xmm3[2],xmm0[2],xmm3[3],xmm0[3]
----------------
pengfei wrote:
> Is this another regression?
Yeah - we're still missing some SimplifyDemanded* handling for X86ISD::VPMADDWD - looking at this now


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110995/new/

https://reviews.llvm.org/D110995



More information about the llvm-commits mailing list