[PATCH] D111781: [flang] Make the frontend driver error out when requesting multiple actions

Thu Nov 4 03:39:16 PDT 2021

jansvoboda11 added a comment.

In D111781#3108253 <https://reviews.llvm.org/D111781#3108253>, @awarzynski wrote:

> I've just added reviewers that recently touched llvm/include/llvm/Option/ArgList.h. For a bit of context, this patch addresses some concerns raised here:
>
> - [flang-dev]: https://lists.llvm.org/pipermail/cfe-dev/2021-October/069132.html (the original thread)
> - [cfe-dev]: https://lists.llvm.org/pipermail/cfe-dev/2021-October/069132.html (a separate thread that focuses on this particular behavior in the context of `clang -cc1`).

Both of those links point to the cfe-dev mailing list.

> I'm not suggesting that a similar change is made in `clang -cc1`, but I definitely wouldn't mind extending this patch so that it covers both `flang-new -cc1` and `clang -cc1`.

Personally, I don't think this is something we'd want for `clang -cc1`. The end users only interact with the driver interface (which will never generate multiple actions) and never see/modify the `-cc1` invocation.
On the other hand, when hacking on Clang, I often grab a `-cc1` invocation and append `-Eonly` to only run the preprocessor. If that resulted in an error and forced me to go through the whole command-line and remove `-c`, I'd be very frustrated.

If the Flang community is okay with this change, I don't have any objections.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111781/new/

https://reviews.llvm.org/D111781