[PATCH] D113127: [NFC][llvm-libtool-darwin] Refactor code

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexander-shaposhnikov requested changes to this revision.
alexander-shaposhnikov added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:235
+// MembersPerArchitectureMap.
+class AddMember {
+public:
----------------
not sure this class adds much value, the name "AddMember" doesn't seem to be a good name for a class either.
There are multiple ways how refactor the existing code (but they would require deeper changes than what the current diff does) and clean up the API but this class doesn't seem to introduce a good abstraction.
 


   
 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113127/new/

https://reviews.llvm.org/D113127