[PATCH] D112696: CycleInfo: Introduce cycles as a generalization of loops

[Jay Foad via Phabricator via llvm-commits]

foad added a reviewer: ruiling.
foad added a comment.

LGTM overall. I only skimmed through the algorithmic parts. Personally I would be happy to take it on trust that the analysis does what Havlak says and works as described, unless someone volunteers to do a much deeper review of the implementation.



================
Comment at: llvm/include/llvm/ADT/GenericCycleInfo.h:296
+  /// GraphTraits implementation and related iteration. Only the cycle
+  /// children and entries are filed in, while the set of blocks
+  /// remains empty.
----------------
Typoe "filed".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112696/new/

https://reviews.llvm.org/D112696