[PATCH] D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline.

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added inline comments.


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1648
+
+std::string DotCfgDiff::attribute(IRChangeDiffType T) const {
+  return "color=" + Colours[T];
----------------
gcc warns about this function being unused:
```
[2174/4649] Building CXX object lib/Passes/CMakeFiles/LLVMPasses.dir/StandardInstrumentations.cpp.o
../lib/Passes/StandardInstrumentations.cpp:1649:13: warning: 'std::string {anonymous}::DotCfgDiff::attribute({anonymous}::IRChangeDiffType) const' defined but not used [-Wunused-function]
 1649 | std::string DotCfgDiff::attribute(IRChangeDiffType T) const {
      |             ^~~~~~~~~~
```
Will it be used or should it be removed (or should it be there even if it's unused)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87202/new/

https://reviews.llvm.org/D87202