[PATCH] D113164: [NFC] Avoid nullptr dereference

[Kan Shengchen via Phabricator via llvm-commits]

skan added inline comments.


================
Comment at: llvm/lib/CodeGen/TypePromotion.cpp:259-260
     return LessOrEqualTypeSize(Store->getValueOperand());
   if (auto *Return = dyn_cast<ReturnInst>(V))
-    return LessOrEqualTypeSize(Return->getReturnValue());
   if (auto *ZExt = dyn_cast<ZExtInst>(V))
----------------
You mean

`Return->getReturnValue()` may return a NULL pointer but `LessOrEqualTypeSize` assumes its argument is never be a NULL?

If the answer is yes, you need to provide a test case tiggering the compfail. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113164/new/

https://reviews.llvm.org/D113164