[PATCH] D113150: Lift VLIWResourceModel, VLIWMachineScheduler, and ConvergingVLIWScheduler into CodeGen/VLIWMachineScheduler

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/VLIWMachineScheduler.h:17
+#include "llvm/CodeGen/MachineScheduler.h"
+#include "llvm/CodeGen/RegisterClassInfo.h"
+#include "llvm/CodeGen/ScheduleHazardRecognizer.h"
----------------
Maybe some of the includes can be replaced with a class forward declaration like `class RegisterClassInfo;` in the header.


================
Comment at: llvm/lib/CodeGen/VLIWMachineScheduler.cpp:45
+
+static cl::opt<bool> IgnoreBBRegPressure("ignore-bb-reg-pressure",
+    cl::Hidden, cl::ZeroOrMore, cl::init(false));
----------------
Maybe the options could be prefixed with `vliw-` or similar...


================
Comment at: llvm/lib/CodeGen/VLIWMachineScheduler.cpp:104-107
+  case TargetOpcode::EXTRACT_SUBREG:
+  case TargetOpcode::INSERT_SUBREG:
+  case TargetOpcode::SUBREG_TO_REG:
+  case TargetOpcode::REG_SEQUENCE:
----------------
Just for my curiosity: Are you really seeing those instructions? I thought they are used in early parts of the codegen pipeline but should be lowered away after `TwoAddressInstructionPass`...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113150/new/

https://reviews.llvm.org/D113150