[PATCH] D112768: [ARM] implement support for TLS register based stack protector

[Ard Biesheuvel via Phabricator via llvm-commits]

ardb marked 2 inline comments as done.
ardb added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3190-3191
+      }
+      CmdArgs.push_back("-target-feature");
+      CmdArgs.push_back("+read-tp-hard");
+    }
----------------
nickdesaulniers wrote:
> ardb wrote:
> > nickdesaulniers wrote:
> > > Isn't this redundant/set elsewhere?
> > No, it is not. The alternative is requiring the user to pass -mtp=cp15 when using the TLS stack protector, which is silly because it is implied.
> Right. Perhaps we could emit `diag::err_drv_argument_not_allowed_with` if the user specified `-mtp=soft` with `-mstack-protector-guard=tls`.
> 
> It looks like a call to clang::driver::tools::arm::getReadTPMode() should being able to tell us whether someone explicitly tried to use soft.
> Right. Perhaps we could emit `diag::err_drv_argument_not_allowed_with` if the user specified `-mtp=soft` with `-mstack-protector-guard=tls`.
> 
> It looks like a call to clang::driver::tools::arm::getReadTPMode() should being able to tell us whether someone explicitly tried to use soft.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112768/new/

https://reviews.llvm.org/D112768