[PATCH] D113101: [Polly][Isl] Use the function unsignedFromIslSize to manage a isl::size object. NFCI

[Riccardo Mori via Phabricator via llvm-commits]

patacca created this revision.
Herald added subscribers: ormris, bmahjour, steven_wu, kbarton, hiraditya, nemanjai.
Herald added a reviewer: bollu.
patacca updated this revision to Diff 384510.
patacca added a comment.
patacca retitled this revision from "[Polly][Isl] Introduce unsignedFromIslSize and islAssert. NFCI" to "[Polly][Isl] Use the function unsignedFromIslSize to manage a isl::size object. NFCI".
patacca edited the summary of this revision.
patacca added a reviewer: Meinersbur.
patacca added a project: Polly.
patacca added a subscriber: pollydev.
patacca edited the summary of this revision.
patacca published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Fix code style


This is part of an effort to reduce the differences between the custom C++ bindings used right now by polly in lib/External/isl/include/isl/isl-noxceptions.h and the official isl C++ interface.
In the official interface the type `isl::size` cannot be casted to an unsigned without previously having checked if it contains a valid value with the function `isl::size::is_error()`.
For this reason two helping functions have been added:

- `IslAssert`: assert that no errors are present in debug builds and just disables the mandatory error check in non-debug builds
- `unisgnedFromIslSIze`: cast the `isl::size` object to `unsigned`

Changes made:

- Add the functions `IslAssert` and `unsignedFromIslSize`
- Add the utility function `rangeIslSize()`
- Retype `MaxDisjunctsInDomain` from `int` to `unsigned`
- Retype `RunTimeChecksMaxAccessDisjuncts` from `int` to `unsigned`
- Retype `MaxDimensionsInAccessRange` from `int` to `unsigned`
- Replaced some usages of `isl_size` to `unsigned` since we aim not to use `isl_size` anymore
- `isl-noexceptions.h` has been generated by https://github.com/patacca/isl/commit/e704f73c88f0b4d88e62e447bdb732cf5914094b

No functional change intended.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113101

Files:
  polly/include/polly/ScheduleTreeTransform.h
  polly/include/polly/ScopInfo.h
  polly/include/polly/Support/ISLTools.h
  polly/lib/Analysis/DependenceInfo.cpp
  polly/lib/Analysis/ScopBuilder.cpp
  polly/lib/Analysis/ScopInfo.cpp
  polly/lib/CodeGen/BlockGenerators.cpp
  polly/lib/CodeGen/PPCGCodeGeneration.cpp
  polly/lib/Exchange/JSONExporter.cpp
  polly/lib/External/isl/include/isl/isl-noexceptions.h
  polly/lib/Support/ISLTools.cpp
  polly/lib/Transform/FlattenAlgo.cpp
  polly/lib/Transform/MatmulOptimizer.cpp
  polly/lib/Transform/MaximalStaticExpansion.cpp
  polly/lib/Transform/ScheduleOptimizer.cpp
  polly/lib/Transform/ScheduleTreeTransform.cpp
  polly/lib/Transform/Simplify.cpp
  polly/lib/Transform/ZoneAlgo.cpp
  polly/unittests/Isl/IslTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113101.384510.patch
Type: text/x-patch
Size: 50445 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211103/e8d6421e/attachment.bin>