[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

[Michael Liao via Phabricator via llvm-commits]

hliao added a comment.

In D112041#3106936 <https://reviews.llvm.org/D112041#3106936>, @nikic wrote:

> I'd still like an answer to:
>
> In D112041#3073464 <https://reviews.llvm.org/D112041#3073464>, @nikic wrote:
>
>> Is it actually necessary to thread this through AssumptionCache, given how InferAddressSpaces is the only place that looks at these assumes?
>
> I'd prefer not to infect AC with TTI if not necessary.

We need `assume` intrinsic to preserve those predicates through optimizations as `infer-addrespace` may run several times. With `assume` used the same way, we probably just duplicate the logic in AC if we want to track them inside this pass. That's not a good practice though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112041/new/

https://reviews.llvm.org/D112041