[PATCH] D112732: [ASan] Process functions in Asan module pass

Wed Nov 3 11:09:00 PDT 2021

kstoimenov added inline comments.

================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1189
+        MPM.addPass(ModuleAddressSanitizerPass(
+            CompileKernel, Recover, ModuleUseAfterScope, UseOdrIndicator,
+            DestructorKind, UseAfterScope, UseAfterReturn));
----------------
rupprecht wrote:
> rupprecht wrote:
> > I'm seeing build errors here, and I'm not sure what this is supposed to be?
> > 
> > ```
> > /home/rupprecht/src/llvm-project/clang/lib/CodeGen/BackendUtil.cpp:1189:37: error: use of undeclared identifier 'ModuleUseAfterScope'; did you mean 'UseAfterScope'?
> >             CompileKernel, Recover, ModuleUseAfterScope, UseOdrIndicator,
> >                                     ^~~~~~~~~~~~~~~~~~~
> >                                     UseAfterScope
> > ```
> > 
> > https://buildkite.com/llvm-project/upstream-bazel-rbe/builds/11193#bbebbf99-a2c1-4959-b6f7-f7fb816591c0
> I see it was reverted already, sorry!
Sorry about breaking the build. I can't understand how my local tests passed. Functions with a long list of boolean params are so error prone. The downside of not using the builder pattern :-( 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112732/new/

https://reviews.llvm.org/D112732