[PATCH] D113035: [InstCombine] enhance vector bitwise select matching

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 3 11:06:45 PDT 2021


spatel added a comment.

In D113035#3106536 <https://reviews.llvm.org/D113035#3106536>, @lebedev.ri wrote:

> Is there test coverage for the edge-case of selecting between vectors themselves? (condition is `i1`)

I'm not imagining the sequence that you are suggesting.
The condition can't be scalar i1 if the other operands are integer vectors. It has to be a vector of the same type or a bitcast from a type with at least as many bits as the other operands.

We have existing tests with bool types starting around line 367 (`@bools`). `@vec_of_bools` is at line 461 - do any of those cover it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113035/new/

https://reviews.llvm.org/D113035



More information about the llvm-commits mailing list