[PATCH] D97937: [AMDGPU][GlobalISel] Transform (fadd (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), z)
Mirko Brkusanin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 3 10:49:26 PDT 2021
- Previous message: [PATCH] D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z)
- Next message: [PATCH] D97938: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fmul u, v)), z) -> (fma x, y, (fma u, v, z))
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
mbrkusanin accepted this revision.
mbrkusanin added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h:382-383
+ // Transform (fadd (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), z)
+ // (fadd (fpext (fmul x, y)), z) -> (fmad (fpext x), (fpext y), z)
+ bool matchCombineFAddFpExtFMulToFMadOrFMA(MachineInstr &MI,
----------------
================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:4543
+
+ // fold (fadd x, (fpext (fmul y, z))) -> (fma (fpext y), (fpext z), x)
+ // Note: Commutes FADD operands.
----------------
Operand names in this comment don't match variables used below (FpExtX, FpExtY). Either update comment or rename variables below.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97937/new/
https://reviews.llvm.org/D97937
- Previous message: [PATCH] D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z)
- Next message: [PATCH] D97938: [AMDGPU][GlobalISel] Transform (fadd (fma x, y, (fmul u, v)), z) -> (fma x, y, (fma u, v, z))
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the llvm-commits
mailing list