[PATCH] D97937: [AMDGPU][GlobalISel] Transform (fadd (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), z)

[Mirko Brkusanin via Phabricator via llvm-commits]

mbrkusanin accepted this revision.
mbrkusanin added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h:382-383
 
+  // Transform (fadd (fpext (fmul x, y)), z) -> (fma (fpext x), (fpext y), z)
+  //           (fadd (fpext (fmul x, y)), z) -> (fmad (fpext x), (fpext y), z)
+  bool matchCombineFAddFpExtFMulToFMadOrFMA(MachineInstr &MI,
----------------



================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:4543
+
+  // fold (fadd x, (fpext (fmul y, z))) -> (fma (fpext y), (fpext z), x)
+  // Note: Commutes FADD operands.
----------------
Operand names in this comment don't match variables used below (FpExtX, FpExtY). Either update comment or rename variables below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97937/new/

https://reviews.llvm.org/D97937